Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cfg): double resolution of labeled statements. #4177

Merged

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jul 10, 2024

Fixes #4173

Copy link

graphite-app bot commented Jul 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

rzvxa commented Jul 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-cfg Area - Control Flow Graph label Jul 10, 2024
@rzvxa rzvxa requested a review from DonIsaac July 10, 2024 23:10
@rzvxa rzvxa marked this pull request as ready for review July 10, 2024 23:11
Copy link

codspeed-hq bot commented Jul 10, 2024

CodSpeed Performance Report

Merging #4177 will not alter performance

Comparing 07-11-fix_cfg_double_resolution_of_labeled_statements (7a059ab) with main (ca0b4fa)

Summary

✅ 31 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 11, 2024
Copy link

graphite-app bot commented Jul 11, 2024

Merge activity

  • Jul 10, 9:39 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 10, 9:39 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 10, 9:43 PM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 07-11-fix_cfg_double_resolution_of_labeled_statements branch from 0591168 to 7a059ab Compare July 11, 2024 01:39
@graphite-app graphite-app bot merged commit 7a059ab into main Jul 11, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 07-11-fix_cfg_double_resolution_of_labeled_statements branch July 11, 2024 01:43
@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Boshen added a commit that referenced this pull request Jul 11, 2024
## [0.20.0] - 2024-07-11

- 5731e39 ast: [**BREAKING**] Store span details inside comment struct
(#4132) (Luca Bruno)

### Features

- 67fe75e ast, ast_codegen: Pass the `scope_id` to the `enter_scope`
event. (#4168) (rzvxa)
- 54cd04a minifier: Implement dce with var hoisting (#4160) (Boshen)
- 44a894a minifier: Implement return statement dce (#4155) (Boshen)
- 725571a napi/transformer: Add `jsx` option to force parsing with jsx
(#4133) (Boshen)

### Bug Fixes

- 48947a2 ast: Put `decorators` before everything else. (#4143) (rzvxa)
- 7a059ab cfg: Double resolution of labeled statements. (#4177) (rzvxa)
- 4a656c3 lexer: Incorrect lexing of large hex/octal/binary literals
(#4072) (DonIsaac)
- 28eeee0 parser: Fix asi error diagnostic pointing at invalid text
causing crash (#4163) (Boshen)

### Performance

- ddfa343 diagnostic: Use `Cow<'static, str>` over `String` (#4175)
(DonIsaac)
- 2203143 semantic: Store unresolved refs in a stack (#4162) (lucab)
- fca9706 semantic: Faster search for leading comments (#4140) (Boshen)

### Documentation

- bdcc298 ast: Update the note regarding the `ast_codegen` markers.
(#4149) (rzvxa)

### Refactor

- 03ad1e3 semantic: Tweak comment argument type (#4157) (lucab)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-cfg Area - Control Flow Graph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: CFG building panics in debug builds
2 participants