Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oxlint): move cli-related exports to cli module #5139

Conversation

DonIsaac
Copy link
Contributor

No description provided.

@DonIsaac DonIsaac marked this pull request as ready for review August 23, 2024 18:43
@github-actions github-actions bot added the A-cli Area - CLI label Aug 23, 2024
@DonIsaac DonIsaac changed the base branch from don/08-22-feat_linter/config_implement_fromiterator_for_lintpluginoptions to graphite-base/5139 August 23, 2024 18:56
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_oxlint_move_cli-related_exports_to_cli_module branch from 10dcdde to 9bf49fc Compare August 23, 2024 18:57
@DonIsaac DonIsaac force-pushed the graphite-base/5139 branch from 1a32f6e to 1ce9630 Compare August 23, 2024 18:57
@DonIsaac DonIsaac changed the base branch from graphite-base/5139 to main August 23, 2024 19:05
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_oxlint_move_cli-related_exports_to_cli_module branch from 9bf49fc to ee24c28 Compare August 23, 2024 19:05
Copy link

codspeed-hq bot commented Aug 23, 2024

CodSpeed Performance Report

Merging #5139 will not alter performance

Comparing don/08-23-refactor_oxlint_move_cli-related_exports_to_cli_module (20d0068) with main (f49e6eb)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/08-23-refactor_oxlint_move_cli-related_exports_to_cli_module branch from ee24c28 to 4a3425f Compare August 23, 2024 19:36
@DonIsaac DonIsaac added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Aug 23, 2024
@DonIsaac DonIsaac marked this pull request as draft August 24, 2024 04:46
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_oxlint_move_cli-related_exports_to_cli_module branch from 4a3425f to 408d46d Compare August 29, 2024 16:01
@DonIsaac DonIsaac marked this pull request as ready for review August 29, 2024 16:05
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_oxlint_move_cli-related_exports_to_cli_module branch from 408d46d to 1d1a365 Compare August 29, 2024 21:12
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 8, 2024
Copy link

graphite-app bot commented Sep 8, 2024

Merge activity

  • Sep 7, 11:08 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 8, 11:26 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 8, 11:35 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the don/08-23-refactor_oxlint_move_cli-related_exports_to_cli_module branch from cf33b7a to 20d0068 Compare September 8, 2024 15:29
@graphite-app graphite-app bot merged commit 20d0068 into main Sep 8, 2024
26 checks passed
@graphite-app graphite-app bot deleted the don/08-23-refactor_oxlint_move_cli-related_exports_to_cli_module branch September 8, 2024 15:35
@oxc-bot oxc-bot mentioned this pull request Sep 12, 2024
Boshen added a commit that referenced this pull request Sep 12, 2024
## [0.9.4] - 2024-09-12

### Features

- 9ca2593 linter: Eslint/sort-keys  (#4845) (Na'aman Hirschfeld)
- 023c160 linter: Impl `Serialize` for `OxlintConfig` (#5594) (DonIsaac)
- 24d6a47 linter: Implement `eslint/no-invalid-regexp` (#5443) (Boshen)

### Bug Fixes

- af6d240 linter: Panic in consistent-function-scoping (#5613)
(DonIsaac)
- 54e2e76 linter: `react/no_set_state` + `react/no_string_refs` rules
find correct parent (#5615) (overlookmotel)
- 3b87ac4 linter: Fix no_unused_vars panic when encountering unicode
(#5582) (Boshen)

### Performance

- bfe9186 linter: Use `cow_replace` instead of `replace` (#5643)
(dalaoshu)
- e3ae5db linter: Use cow_to_ascii_lowercase/uppercase (#5637) (heygsc)
- a0370bf linter: Use cow_utils in no_script_url (#5633) (heygsc)
- 37e922c linter: `eslint/no_shadow_restricted_names` use
`run_on_symbol` (#5618) (overlookmotel)
- 0b7fccf linter: `react/no_set_state` + `react/no_string_refs` rules
reduce iteration over ancestors (#5616) (overlookmotel)
- 2c3f3fe linter: Make `jsx_key` slightly faster (#5585) (Boshen)
- cd81d12 linter: Add `should_run` to check path only once to
nextjs/no_typos (#5584) (Boshen)
- d18c896 rust: Use `cow_utils` instead (#5664) (dalaoshu)

### Documentation

- 64f9575 linter: Add plugin usage to example with configuration
(Boshen)
- 8c9179d linter: Fix typos (#5591) (Brian Donovan)

### Refactor

- 9e9435f linter: Add `LintFilter` (#5685) (DonIsaac)
- 4f70fe5 linter: Start internal/external split of LintPluginOptions
(#5660) (DonIsaac)
- 5ae9b48 linter: Start internal/external split of `OxlintOptions`
(#5659) (DonIsaac)
- c8bc6f0 linter: Use `std::ptr::eq` (#5649) (overlookmotel)
- a37c064 linter: Use `ContentHash` for `no_duplicate_case`; remove
`calculate_hash` (#5648) (Boshen)
- 0b3c1d7 linter: Start internal/external split of `OxlintConfig`
(#5595) (DonIsaac)
- 89bdf55 linter: Inline `Rule` trait default methods (#5619)
(overlookmotel)
- afea8d5 linter: Rename `Rule` trait method params (#5617)
(overlookmotel)
- 4e748b5 linter: Replace ast "compare by hash" to "compare by content"
(#5602) (dalaoshu)
- bac03e3 linter: Make fields of `LintServiceOptions` private (#5593)
(DonIsaac)
- 2661d8b linter: Jest prefer_strict_equal (#5588) (IWANABETHATGUY)
- 20d0068 oxlint: Move cli-related exports to `cli` module (#5139)
(DonIsaac)
- 067f9b5 semantic: Introduce `IsGlobalReference` trait (#5672)
(Boshen)- 26d9235 Enable clippy::ref_as_ptr (#5577) (夕舞八弦)

### Testing

- 8e79f8d linter: Add class method test cases for `oxc/no-async-await`
(#5550) (DonIsaac)
- 3835189 linter: Add test case for no_unused_vars in 3b87ac4 (Boshen)
- 5f27551 linter: Add a passing case to no_undef (#5580) (Boshen)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This was referenced Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants