perf(linter/react): add should_run conditions for react rules

[jelly]

Only run the React rules on files containing JSX elements.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[camc314]

hmm what about createElement calls?

these could be called inside ts/js files

[codspeed-hq]

CodSpeed Performance Report

Merging #5402 will not alter performance

_{Comparing jelly:should_run-react (9f65457) with main (953344d)}

Summary

✅ 28 untouched benchmarks

[jelly]

hmm what about createElement calls?

these could be called inside ts/js files

Good point, I see two issues here:

• button_has_type and possibly other rules have CreateElement() and are marked as should_run => is_jsx()
• There are no tests to validate this, or better said, the unittest framework does not seem to invoke is_jsx() or wrongly assumes it is jsx :).

Update

Looking up how is_jsx is implemented createElement will work:

        let variant = match extension {
            "js" | "mjs" | "cjs" | "jsx" | "tsx" => LanguageVariant::Jsx,

Except that .ts is missing. But then it seems adding should_run doesn't give a lot of performance optimisation as it only skips .ts, mts, cts and .d.ts files. If rules which only check for JSX Elements and not also createElement.

One can argue that not a lot of codebases has this divide. Then again it is totally valid to have JSX elements in .js files, see:

facebook/create-react-app#87

So my point is kinda moot :-)

[jelly]

Updated the PR to only include should_run for when there is no React.createElement or Rules of hooks as they work for classes as well