Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(napi): export a pure parse function for benchmark purposes #571

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jul 19, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #571 (b4e35dc) into main (6310625) will increase coverage by 0.80%.
The diff coverage is 89.55%.

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   89.26%   90.07%   +0.80%     
==========================================
  Files         154      191      +37     
  Lines       29760    36022    +6262     
==========================================
+ Hits        26566    32446    +5880     
- Misses       3194     3576     +382     
Impacted Files Coverage Δ
crates/oxc_ast/src/ast/jsx.rs 55.10% <ø> (ø)
crates/oxc_ast/src/ast_kind.rs 27.16% <0.00%> (+10.40%) ⬆️
crates/oxc_ast/src/lib.rs 0.00% <ø> (ø)
crates/oxc_ast/src/span.rs 35.58% <0.00%> (-2.62%) ⬇️
crates/oxc_cli/src/lib.rs 0.00% <0.00%> (ø)
crates/oxc_cli/src/lint/error.rs 0.00% <0.00%> (ø)
crates/oxc_cli/src/lint/isolated_handler.rs 0.00% <0.00%> (ø)
crates/oxc_cli/src/lint/mod.rs 0.00% <0.00%> (-98.45%) ⬇️
crates/oxc_cli/src/lint/module_tree_handler.rs 0.00% <0.00%> (ø)
crates/oxc_cli/src/type_check/mod.rs 0.00% <0.00%> (ø)
... and 119 more

... and 35 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Boshen Boshen merged commit 3f84a7f into main Jul 19, 2023
@Boshen Boshen deleted the napi-bench branch July 19, 2023 04:55
@github-actions
Copy link
Contributor

Benchmark Results

Linux

group                            main                                   pr
-----                            ----                                   --
minifier/antd.js                 1.00    243.0±3.01ms    26.2 MB/sec    1.00    242.6±2.85ms    26.3 MB/sec
minifier/react.development.js    1.00      2.6±0.01ms    26.5 MB/sec    1.00      2.6±0.01ms    26.6 MB/sec
minifier/typescript.js           1.01    409.9±4.66ms    25.2 MB/sec    1.00    407.4±4.18ms    25.3 MB/sec
minifier/vue.js                  1.00     15.6±0.11ms    20.9 MB/sec    1.00     15.6±0.14ms    20.9 MB/sec
parser/antd.js                   1.01     78.2±1.24ms    81.5 MB/sec    1.00     77.2±0.78ms    82.5 MB/sec
parser/react.development.js      1.00    833.7±3.25µs    82.5 MB/sec    1.00    835.2±4.64µs    82.4 MB/sec
parser/typescript.js             1.00    129.8±0.23ms    79.5 MB/sec    1.00    130.0±0.47ms    79.4 MB/sec
parser/vue.js                    1.00      5.4±0.01ms    60.1 MB/sec    1.00      5.4±0.01ms    60.1 MB/sec
semantic/antd.js                 1.00     77.4±3.57ms    82.4 MB/sec    1.00     77.1±3.67ms    82.7 MB/sec
semantic/react.development.js    1.00    822.0±4.53µs    83.7 MB/sec    1.00    820.7±3.49µs    83.8 MB/sec
semantic/typescript.js           1.00    170.0±5.52ms    60.7 MB/sec    1.00    170.4±6.40ms    60.5 MB/sec
semantic/vue.js                  1.00      5.3±0.06ms    61.0 MB/sec    1.00      5.4±0.05ms    60.9 MB/sec

Windows

group                            main                                   pr
-----                            ----                                   --
minifier/antd.js                 1.06   350.3±14.13ms    18.2 MB/sec    1.00    330.0±8.01ms    19.3 MB/sec
minifier/react.development.js    1.00      3.4±0.12ms    20.2 MB/sec    1.00      3.4±0.13ms    20.2 MB/sec
minifier/typescript.js           1.02   523.1±17.01ms    19.7 MB/sec    1.00   512.6±19.64ms    20.1 MB/sec
minifier/vue.js                  1.00     20.5±0.59ms    15.9 MB/sec    1.01     20.7±0.58ms    15.7 MB/sec
parser/antd.js                   1.00     89.4±2.71ms    71.3 MB/sec    1.00     89.8±2.44ms    71.0 MB/sec
parser/react.development.js      1.00   948.6±18.99µs    72.5 MB/sec    1.00   946.2±12.93µs    72.7 MB/sec
parser/typescript.js             1.00    148.6±2.88ms    69.4 MB/sec    1.01    149.6±3.55ms    68.9 MB/sec
parser/vue.js                    1.00      6.0±0.10ms    54.0 MB/sec    1.01      6.1±0.07ms    53.6 MB/sec
semantic/antd.js                 1.10    112.6±6.61ms    56.7 MB/sec    1.00    102.3±5.58ms    62.4 MB/sec
semantic/react.development.js    1.00  1089.2±22.50µs    63.2 MB/sec    1.02  1116.0±36.05µs    61.6 MB/sec
semantic/typescript.js           1.05   237.1±18.00ms    43.5 MB/sec    1.00   225.4±11.96ms    45.8 MB/sec
semantic/vue.js                  1.00      7.5±0.98ms    43.2 MB/sec    1.03      7.8±0.43ms    41.8 MB/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant