feat(eslint/jsx_a11y): implement anchor_ambiguous_text #5729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a remaining clippy issue with passing
COW<_, str>
which I simply can't resolve, but maybe there is more to fix first in my approach.Currently this PR might do a bit too much allocations:
trim()
in there as a "maybe optimisation" to skip the whole string modification shenaniganscow_replace
?if normalized_str.contains(char::is_whitespace) {
is worth it? But my gut feeling is that it is, as it deconstructs and constructs a whole String<>