Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(linter, ast-tools, coverage): Use FxHashSet instead of std::collections::HashSet #6001

Conversation

camchenry
Copy link
Contributor

No description provided.

Copy link

graphite-app bot commented Sep 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Sep 23, 2024

CodSpeed Performance Report

Merging #6001 will not alter performance

Comparing 09-23-perf_linter_ast-tools_coverage_use_fxhashset_instead_of_std_collections_hashset_ (0ab41b9) with 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ (e14e488)

Summary

✅ 29 untouched benchmarks

@camchenry
Copy link
Contributor Author

I think the snapshot changes are because my editor automatically stripped some whitespace from some lines. I can revert if desired, but at least this way it won't be able to happen again in the future.

@camchenry camchenry marked this pull request as ready for review September 23, 2024 17:52
Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@overlookmotel overlookmotel force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch 2 times, most recently from c264de3 to 637c563 Compare September 23, 2024 18:35
@overlookmotel overlookmotel force-pushed the 09-23-perf_linter_ast-tools_coverage_use_fxhashset_instead_of_std_collections_hashset_ branch from ed9bab1 to 0ab41b9 Compare September 23, 2024 18:35
@camchenry camchenry force-pushed the 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ branch 2 times, most recently from 7f6cee0 to d32b8da Compare September 23, 2024 22:37
@Boshen Boshen changed the base branch from 09-23-perf_ban_std_collections_hashmap_in_favor_of_fxhashmap_ to graphite-base/6001 September 24, 2024 05:08
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 24, 2024
Copy link

graphite-app bot commented Sep 24, 2024

Merge activity

  • Sep 24, 4:41 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 24, 4:42 AM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Sep 24, 4:42 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@Boshen Boshen force-pushed the 09-23-perf_linter_ast-tools_coverage_use_fxhashset_instead_of_std_collections_hashset_ branch from 0ab41b9 to 56ba87c Compare September 24, 2024 08:59
@Boshen Boshen changed the base branch from graphite-base/6001 to main September 24, 2024 08:59
@Boshen Boshen merged commit 65d8f9e into main Sep 24, 2024
3 checks passed
@Boshen Boshen deleted the 09-23-perf_linter_ast-tools_coverage_use_fxhashset_instead_of_std_collections_hashset_ branch September 24, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools A-linter Area - Linter A-prettier Area - Prettier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants