Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): move impl GetAddress for Statement #6742

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 21, 2024

Follow-on after #6738. Since GetAddress is now defined in oxc_allocator crate, impl GetAddress for Statement doesn't need its own file.

Copy link

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 21, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 21, 2024 14:17
@overlookmotel overlookmotel requested a review from Dunqing October 21, 2024 14:18
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #6742 will not alter performance

Comparing 10-21-refactor_ast_move_impl_getaddress_for_statement_ (b66ae2e) with main (1248557)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
Copy link
Member

Boshen commented Oct 21, 2024

Merge activity

  • Oct 21, 10:30 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 21, 10:30 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 21, 10:52 AM EDT: A user merged this pull request with the Graphite merge queue.

Follow-on after #6738. Since `GetAddress` is now defined in `oxc_allocator` crate, `impl GetAddress for Statement` doesn't need its own file.
@Boshen Boshen force-pushed the 10-21-refactor_ast_move_impl_getaddress_for_statement_ branch from 419815a to b66ae2e Compare October 21, 2024 14:45
@graphite-app graphite-app bot merged commit b66ae2e into main Oct 21, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-21-refactor_ast_move_impl_getaddress_for_statement_ branch October 21, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants