Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): all ast_util functions take Semantic #6753

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Oct 21, 2024

Needed in oxc/no-map-spread rule.

Copy link

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

DonIsaac commented Oct 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 21, 2024
@DonIsaac DonIsaac marked this pull request as ready for review October 21, 2024 18:10
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #6753 will not alter performance

Comparing don/10-21-refactor_linter_all_ast_util_functions_take_semantic (b884577) with main (b66ae2e)

Summary

✅ 30 untouched benchmarks

@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
Copy link
Contributor Author

DonIsaac commented Oct 21, 2024

Merge activity

  • Oct 21, 6:38 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 21, 6:38 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 21, 6:46 PM EDT: A user merged this pull request with the Graphite merge queue.

@DonIsaac DonIsaac force-pushed the don/10-21-refactor_linter_impl_deref_target_semantic_for_lintcontext_ branch from 43658a7 to 744aa74 Compare October 21, 2024 22:39
@DonIsaac DonIsaac force-pushed the don/10-21-refactor_linter_all_ast_util_functions_take_semantic branch from 20bb0c5 to b884577 Compare October 21, 2024 22:40
Base automatically changed from don/10-21-refactor_linter_impl_deref_target_semantic_for_lintcontext_ to main October 21, 2024 22:43
@graphite-app graphite-app bot merged commit b884577 into main Oct 21, 2024
27 checks passed
@graphite-app graphite-app bot deleted the don/10-21-refactor_linter_all_ast_util_functions_take_semantic branch October 21, 2024 22:46
Boshen added a commit that referenced this pull request Oct 22, 2024
## [0.10.2] - 2024-10-22

### Features

- dbe1972 linter: Import/no-cycle should turn on ignore_types by default
(#6761) (Boshen)
- 619d06f linter: Fix suggestion for `eslint:no_empty_static_block` rule
(#6732) (Tapan Prakash)

### Bug Fixes


### Performance

- 8387bac linter: Apply small file optimization, up to 30% faster
(#6600) (camchenry)

### Refactor

- b884577 linter: All ast_util functions take Semantic (#6753)
(DonIsaac)
- 744aa74 linter: Impl `Deref<Target = Semantic>` for `LintContext`
(#6752) (DonIsaac)
- 6ffdcc0 oxlint: Lint/mod.rs -> lint.rs (#6746) (Boshen)

### Testing

- b03cec6 oxlint: Add `--fix` test case (#6747) (Boshen)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants