Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): print negative bigint 1n- -1n correctly after constant folding #6798

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Oct 23, 2024

closes #6767

Copy link

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier A-codegen Area - Code Generation labels Oct 23, 2024
Copy link
Member Author

Boshen commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the C-bug Category - Bug label Oct 23, 2024
@Boshen Boshen force-pushed the 10-23-fix_codegen_print_negative_bigint_1n-_-1n_correctly_after_constant_folding branch from 03bfa0b to 2f6ad42 Compare October 23, 2024 04:56
Copy link

graphite-app bot commented Oct 23, 2024

Merge activity

@graphite-app graphite-app bot merged commit 2f6ad42 into main Oct 23, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-23-fix_codegen_print_negative_bigint_1n-_-1n_correctly_after_constant_folding branch October 23, 2024 05:01
Copy link

codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #6798 will not alter performance

Comparing 10-23-fix_codegen_print_negative_bigint_1n-_-1n_correctly_after_constant_folding (2f6ad42) with main (b4bc300)

Summary

✅ 30 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area - Code Generation A-minifier Area - Minifier C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codegen: expressions like 1n- -1n
1 participant