Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/typescript): use TraverseCtx::generate_binding to create a symbol #6806

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 23, 2024

Obviously, we reduce much code after using this API

Copy link

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Oct 23, 2024

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 23, 2024
@Dunqing Dunqing changed the title refactor(transformer/typescript): use TraverseCtx::generate_binding to create a symbol refactor(transformer/typescript): use TraverseCtx::generate_binding to create a symbol Oct 23, 2024
Copy link

codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #6806 will not alter performance

Comparing 10-23-refactor_transformer_typescript_use_traversectx_generate_binding_to_create_a_symbol (fdd69e4) with main (22355f7)

Summary

✅ 30 untouched benchmarks

Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 23, 2024
Copy link
Contributor

overlookmotel commented Oct 23, 2024

Merge activity

  • Oct 23, 11:43 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 23, 11:44 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 23, 11:59 AM EDT: A user merged this pull request with the Graphite merge queue.

… to create a symbol (#6806)

Obviously, we reduce much code after using this API
@overlookmotel overlookmotel force-pushed the 10-23-feat_traverse_add_generate_binding_and_generate_binding_current_scope_apis_in_context branch from aad68b0 to c96e739 Compare October 23, 2024 15:50
@overlookmotel overlookmotel force-pushed the 10-23-refactor_transformer_typescript_use_traversectx_generate_binding_to_create_a_symbol branch from 4c2bdc3 to fdd69e4 Compare October 23, 2024 15:50
Base automatically changed from 10-23-feat_traverse_add_generate_binding_and_generate_binding_current_scope_apis_in_context to main October 23, 2024 15:55
@graphite-app graphite-app bot merged commit fdd69e4 into main Oct 23, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 10-23-refactor_transformer_typescript_use_traversectx_generate_binding_to_create_a_symbol branch October 23, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants