Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semantic): add move_binding API in ScopeTree #6808

Merged

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 23, 2024

Part of #6658

This API is useful when we want to move a scope to another scope

Copy link

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@Dunqing Dunqing changed the title feat(semantic): add move_binding API in ScopeTree feat(semantic): add move_binding API in ScopeTree Oct 23, 2024
@github-actions github-actions bot added A-semantic Area - Semantic C-enhancement Category - New feature or request labels Oct 23, 2024
@Dunqing Dunqing requested a review from overlookmotel October 23, 2024 08:25
Copy link

codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #6808 will not alter performance

Comparing 10-23-feat_semantic_add_move_binding_api_in_scopetree (5928f04) with main (e7e60da)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel changed the base branch from 10-23-feat_semantic_add_change_parent_id_api_in_scopetree to graphite-base/6808 October 23, 2024 15:29
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 23, 2024
Copy link
Contributor

overlookmotel commented Oct 23, 2024

Merge activity

  • Oct 23, 11:30 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 23, 11:31 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 23, 11:41 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/6808 to main October 23, 2024 15:35
Part of #6658

This API is useful when we want to move a scope to another scope
@overlookmotel overlookmotel force-pushed the 10-23-feat_semantic_add_move_binding_api_in_scopetree branch from d3731c9 to 5928f04 Compare October 23, 2024 15:36
@graphite-app graphite-app bot merged commit 5928f04 into main Oct 23, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-23-feat_semantic_add_move_binding_api_in_scopetree branch October 23, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants