-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(transformer/react-refresh): avoid re-creating Atom
s
#6816
refactor(transformer/react-refresh): avoid re-creating Atom
s
#6816
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #6816 will not alter performanceComparing Summary
|
6069c88
to
55a2591
Compare
2e5a190
to
8b21792
Compare
Merge activity
|
Store `BoundIdentifier` in `registrations`. This allows removing the call to `ctx.ast.atom()` which re-allocates a new `Atom` into the arena - unnecessary as it's already been allocated when the UID was created. It's unfortunate that `Semantic` stores symbol names as `CompactStr`s instead of `Atom`s, otherwise we could get the name as an `Atom` without re-allocating it. Hopefully we can make that change in future, and then reduce `BoundIdentifier` to just contain the `SymbolId`. But for now, we are kind of stuck with it.
55a2591
to
8316069
Compare
8b21792
to
4f6dc22
Compare
Store
BoundIdentifier
inregistrations
. This allows removing the call toctx.ast.atom()
which re-allocates a newAtom
into the arena - unnecessary as it's already been allocated when the UID was created.It's unfortunate that
Semantic
stores symbol names asCompactStr
s instead ofAtom
s, otherwise we could get the name as anAtom
without re-allocating it. Hopefully we can make that change in future, and then reduceBoundIdentifier
to just contain theSymbolId
. But for now, we are kind of stuck with it.