Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minifier): do not remove binary expressions #6829

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Oct 23, 2024

@camc314 I removed this minification as its doing way too much.

Copy link

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Oct 23, 2024
Copy link

graphite-app bot commented Oct 23, 2024

Merge activity

@Boshen Boshen force-pushed the 10-23-fix_minifier_do_not_remove_binary_expressions branch from 45f81da to ec5a19b Compare October 23, 2024 16:07
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 23, 2024
@Boshen Boshen requested a review from camc314 October 23, 2024 16:09
@camc314
Copy link
Contributor

camc314 commented Oct 23, 2024

wow
i guess it should only remove comparison ops

@graphite-app graphite-app bot merged commit ec5a19b into main Oct 23, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 10-23-fix_minifier_do_not_remove_binary_expressions branch October 23, 2024 16:17
Copy link

codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #6829 will not alter performance

Comparing 10-23-fix_minifier_do_not_remove_binary_expressions (ec5a19b) with main (2aa763c)

Summary

✅ 30 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants