Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rulegen): add module definitions for new rules #6845

Merged

Conversation

camchenry
Copy link
Contributor

@camchenry camchenry commented Oct 24, 2024

Makes new rule creation a little bit easier by automatically adding the rule definition to rules.rs with the proper alphabetical order.

Example:

Screen.Recording.2024-10-24.at.12.23.44.AM.mov

Copy link

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Oct 24, 2024
@camchenry camchenry force-pushed the 10-24-feat_rulegen_add_module_definitions_for_new_rules branch from 1c4d16b to 0eca37b Compare October 24, 2024 04:31
@camchenry camchenry marked this pull request as ready for review October 24, 2024 04:31
@Boshen
Copy link
Member

Boshen commented Oct 24, 2024

Crazy!

@Boshen Boshen merged commit 04b4bae into main Oct 24, 2024
26 checks passed
@Boshen Boshen deleted the 10-24-feat_rulegen_add_module_definitions_for_new_rules branch October 24, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants