Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(minifier): remove extra compress options #6893

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Oct 25, 2024

Closure Compiler and ESBuild does not have these kind of granularity.

Copy link

graphite-app bot commented Oct 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Oct 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 25, 2024
@Boshen Boshen changed the base branch from minifier-late to graphite-base/6893 October 25, 2024 16:12
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 25, 2024
Copy link

graphite-app bot commented Oct 25, 2024

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/6893 to main October 25, 2024 16:18
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 25, 2024
Copy link

codspeed-hq bot commented Oct 25, 2024

CodSpeed Performance Report

Merging #6893 will not alter performance

Comparing 10-26-refactor_minifier_remove_extra_compress_options (741571f) with main (3e7507f)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen force-pushed the 10-26-refactor_minifier_remove_extra_compress_options branch from 0082046 to e6c597e Compare October 26, 2024 01:25
Closure Compiler and ESBuild does not have these kind of granularity.
@Boshen Boshen force-pushed the 10-26-refactor_minifier_remove_extra_compress_options branch from e6c597e to 741571f Compare October 26, 2024 01:30
@graphite-app graphite-app bot merged commit 741571f into main Oct 26, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-26-refactor_minifier_remove_extra_compress_options branch October 26, 2024 01:35
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
Closure Compiler and ESBuild does not have these kind of granularity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant