Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semantic): resolve function return type to function parent scope #7245

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Nov 12, 2024

closes #6387

@Boshen Boshen requested a review from Dunqing November 12, 2024 05:49
Copy link

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #7245 will not alter performance

Comparing 11-12-fix_semantic_resolve_function_return_type_to_function_parent_scope (b576253) with main (20fe3cd)

Summary

✅ 30 untouched benchmarks

Comment on lines +1674 to +1675
// Resolve identifier references in return type.
self.resolve_references_for_current_scope();
Copy link
Member

@Dunqing Dunqing Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, we don't have extra logic in Visitor to resolve, so I think you should use the way #6388 does

Let me double-check this, I need to do some test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I forgot about #6388. I think it fixes the issue, I just needed to add some tests, and I didn't get around to doing that.

@Boshen Boshen closed this Nov 21, 2024
@Boshen Boshen deleted the 11-12-fix_semantic_resolve_function_return_type_to_function_parent_scope branch December 2, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return type of function incorrectly resolved
3 participants