Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): add proper support for findIndex and findLastIndex for unicorn/prefer-array-some #7405

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

pumano
Copy link
Contributor

@pumano pumano commented Nov 21, 2024

closes #7404

Copy link

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Nov 21, 2024
@pumano pumano force-pushed the fix/prefer-array-some-find-index branch from 83cd47b to b78135c Compare November 21, 2024 18:22
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #7405 will not alter performance

Comparing pumano:fix/prefer-array-some-find-index (b78135c) with main (0918e52)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen merged commit 9002e97 into oxc-project:main Nov 22, 2024
27 checks passed
@Boshen
Copy link
Member

Boshen commented Nov 22, 2024

Thank you!

Boshen added a commit that referenced this pull request Nov 23, 2024
## [0.13.1] - 2024-11-23

### Features

- 4ad26b9 linter: Add `no-promise-in-callback` (#7307) (no-yan)
- 9558087 oxlint: Auto detect config file in CLI (#7348) (Alexander S.)

### Bug Fixes

- 8507464 linter: Hanging when source has syntax/is flow (#7432)
(Cameron)
- e88cf1b linter: Make `overrides` globs relative to config path (#7407)
(camchenry)
- 9002e97 linter: Add proper support for findIndex and findLastIndex for
`unicorn/prefer-array-some` (#7405) (Dmitry Zakharov)

### Documentation

- 6730e3e linter: Add more examples for `unicorn/prefer-array-some`
(#7411) (Dmitry Zakharov)

### Refactor

- 6c0d31b linter: Remove useless `const` declaration (#7430) (Song Gao)
- c8adc46 linter/no-unused-vars: Improve implementation to remove using
SymbolFlags::Export (#7412) (Dunqing)
- c90537f linter/only-used-in-recursion: Improve implementation to
remove using SymbolFlags::Export (#7413) (Dunqing)

### Testing

- 779f479 editor: Check if workspace configuration is updated (#7403)
(Alexander S.)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: false positive for unicorn/prefer-array-some
3 participants