Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(semantic): remove SymbolFlags::TypeLiteral #7415

Merged

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 22, 2024

No description provided.

Copy link

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #7415 will not alter performance

Comparing 11-22-refactor_semantic_try_to_shrink_symbolflags_to_u16 (d7d0735) with main (7236d14)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen changed the base branch from 11-22-refactor_semantic_remove_symbolflags_export to graphite-base/7415 November 22, 2024 09:18
@Boshen Boshen force-pushed the graphite-base/7415 branch from 338571d to 27b2268 Compare November 22, 2024 09:31
@Boshen Boshen force-pushed the 11-22-refactor_semantic_try_to_shrink_symbolflags_to_u16 branch from a18a69a to 46b007b Compare November 22, 2024 09:31
@Boshen Boshen changed the base branch from graphite-base/7415 to main November 22, 2024 09:32
@Boshen Boshen force-pushed the 11-22-refactor_semantic_try_to_shrink_symbolflags_to_u16 branch 2 times, most recently from d052bdd to 437c699 Compare November 25, 2024 11:20
@Boshen Boshen changed the title refactor(semantic): try to shrink SymbolFlags to u16 refactor(semantic): remove SymbolFlags::TypeLiteral Nov 25, 2024
@Boshen Boshen marked this pull request as ready for review November 25, 2024 11:20
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 25, 2024
Copy link
Member

Boshen commented Nov 25, 2024

Merge activity

  • Nov 25, 6:20 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 25, 6:31 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 25, 6:42 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 11-22-refactor_semantic_try_to_shrink_symbolflags_to_u16 branch from 437c699 to 92ac95e Compare November 25, 2024 11:32
@Boshen Boshen force-pushed the 11-22-refactor_semantic_try_to_shrink_symbolflags_to_u16 branch from 92ac95e to d7d0735 Compare November 25, 2024 11:34
@graphite-app graphite-app bot merged commit d7d0735 into main Nov 25, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-22-refactor_semantic_try_to_shrink_symbolflags_to_u16 branch November 25, 2024 11:42
This was referenced Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants