Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): false positive in eslint/prefer-object-has-own #7463

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

shulaoda
Copy link
Contributor

closes #7450

Copy link

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Nov 25, 2024
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #7463 will not alter performance

Comparing shulaoda:fix/eslint-prefer-object-hash-own (f641266) with main (88ddce4)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen merged commit db6558f into oxc-project:main Nov 25, 2024
27 checks passed
@shulaoda shulaoda deleted the fix/eslint-prefer-object-hash-own branch November 25, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic byte index 1 is not a char boundary in crates/oxc_span/src/span/mod.rs
2 participants