Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minifier): do not fold if statement block with lexical declaration #7519

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Nov 28, 2024

No description provided.

Copy link

graphite-app bot commented Nov 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Nov 28, 2024

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Nov 28, 2024
@Boshen Boshen marked this pull request as draft November 28, 2024 08:54
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #7519 will not alter performance

Comparing 11-28-fix_minifier_do_not_fold_if_statement_block_with_lexical_declaration (896ff86) with main (625a5ba)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen marked this pull request as ready for review November 28, 2024 09:15
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 28, 2024
@Boshen Boshen changed the base branch from 11-28-refactor_minifier_improve_ast_passes to graphite-base/7519 November 28, 2024 09:31
@Boshen Boshen force-pushed the graphite-base/7519 branch from 79021e3 to 625a5ba Compare November 28, 2024 10:30
@Boshen Boshen force-pushed the 11-28-fix_minifier_do_not_fold_if_statement_block_with_lexical_declaration branch from 5545b1d to 98b5e40 Compare November 28, 2024 10:30
@Boshen Boshen changed the base branch from graphite-base/7519 to main November 28, 2024 10:31
@Boshen Boshen force-pushed the 11-28-fix_minifier_do_not_fold_if_statement_block_with_lexical_declaration branch from 98b5e40 to 4f1b384 Compare November 28, 2024 10:31
Copy link

graphite-app bot commented Nov 28, 2024

Merge activity

@Boshen Boshen force-pushed the 11-28-fix_minifier_do_not_fold_if_statement_block_with_lexical_declaration branch from 4f1b384 to 896ff86 Compare November 28, 2024 10:37
@graphite-app graphite-app bot merged commit 896ff86 into main Nov 28, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 11-28-fix_minifier_do_not_fold_if_statement_block_with_lexical_declaration branch November 28, 2024 10:42
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant