perf(ast): `move_expression` and `move_statement` produce dummy with no span #7995

overlookmotel · 2024-12-18T15:02:13Z

The purpose of AstBuilder::move_* methods is to create dummy nodes which will later be replaced again. Give the dummy nodes empty spans as it's faster, and no point in them having a real span.

overlookmotel · 2024-12-18T15:02:28Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2024-12-18T15:10:54Z

CodSpeed Performance Report

Merging #7995 will not alter performance

_{Comparing 12-18-perf_ast_move_expression_and_move_statement_produce_dummy_with_no_span (c0dd3f8) with main (f1adf9f)}

Summary

✅ 29 untouched benchmarks

graphite-app · 2024-12-20T03:09:44Z

Merge activity

Dec 19, 10:09 PM EST: A user added this pull request to the Graphite merge queue.
Dec 19, 10:37 PM EST: A user merged this pull request with the Graphite merge queue.

…no span (#7995) The purpose of `AstBuilder::move_*` methods is to create dummy nodes which will later be replaced again. Give the dummy nodes empty spans as it's faster, and no point in them having a real span.

## [0.43.0] - 2024-12-21 - de4c772 traverse: [**BREAKING**] Rename `Ancestor::is_via_*` methods to `is_parent_of_*` (#8031) (overlookmotel) - ed75e42 semantic: [**BREAKING**] Make SymbolTable fields `pub(crate)` instead of `pub` (#7999) (Boshen) ### Features - 75b775c allocator: `Vec<u8>::into_string` (#8017) (overlookmotel) - 8547e02 ast: Implement `allocator_api2` for `Allocator` (#8043) (Boshen) - 63a95e4 ast: Add `AstBulder::move_property_key` (#7998) (overlookmotel) - 897a1a8 transformer/class-properties: Exit faster from super replacement visitor (#8028) (overlookmotel) - 3ea4109 transformer/class-properties: Transform super update expressions within static prop initializer (#7997) (Dunqing) - cc57db3 transformer/class-properties: Transform super assignment expressions within static prop initializer (#7991) (Dunqing) - 6b6444b traverse: Record current block scope (#8007) (overlookmotel) ### Bug Fixes - 043252d transformer/class-properties: Replace `this` and class name in static blocks (#8035) (overlookmotel) - 273795d transformer/class-properties: Run other transforms on static properties, static blocks, and computed keys (#7982) (overlookmotel) ### Performance - c0dd3f8 ast: `move_expression` and `move_statement` produce dummy with no span (#7995) (overlookmotel) - 862838f codegen: Remove useless to_owned (#8014) (Dunqing) - 2736657 semantic: Allocate `UnresolvedReferences` in allocator (#8046) (Boshen) - 2e8872c semantic: Allocate child scope in allocator (#8045) (Boshen) - 414e828 semantic: Allocate symbol data in Allocator (#8012) (Boshen) - 7aebed0 semantic: Allocate `Bindings` in allocator (#8021) (Boshen) - 0f9308f transformer/react-refresh: Reduce allocations (#8018) (overlookmotel) - 0deb9e6 transformer/react-refresh: Reserve capacity in hook key string (#8016) (overlookmotel) - 7b70347 transformer/react-refresh: Avoid allocating string in each hook call (#8013) (Dunqing) ### Documentation - df5c341 ast: Improve docs for `AstBuilder::move_*` methods (#7994) (overlookmotel) ### Refactor - f1adf9f semantic: `ScopeTree::rename_binding` remove old binding first (#8020) (overlookmotel) - 02f968d semantic: Change `Bindings` to a plain `FxHashMap` (#8019) (Boshen) - e7476a1 semantic: Remove `serialize` (#8015) (Boshen) - 1cf7b83 semantic: Simplify handling namespace stack (#7987) (Dunqing) - 48cb52b semantic: Remove resetting `current_reference_flags` in visit functions (#7986) (Dunqing) - 3250a47 semantic: Remove unused current_symbol_flags (#7985) (Dunqing) - efe96ec semantic: Use `Stack` for function stack node ids (#7984) (Dunqing) - ac097e9 transformer/class-properties: Rename file (#8036) (overlookmotel) - 059a5dd transformer/class-properties: Do not pass `ScopeId` into `insert_instance_inits` (#8001) (overlookmotel) - 0a38eea transformer/class-properties: Use `temp_var_name_base` to generate temp var names for `super` transform (#8004) (overlookmotel) - d1b7181 transformer/class-properties: Rename var (#8006) (overlookmotel) - 5a23d72 transformer/class-properties: Remove outdated comment (#8000) (overlookmotel) - b3a5f3e transformer/class-properties: Mark `transform_assignment_expression_if_super_member_assignment_target` as inline (#7993) (Dunqing) ### Testing - bcb33c0 semantic: Add a test for catch parameters reference (#7988) (Dunqing) Co-authored-by: Boshen <[email protected]>

overlookmotel mentioned this pull request Dec 18, 2024

docs(ast): improve docs for AstBuilder::move_* methods #7994

Merged

github-actions bot added A-ast Area - AST C-performance Category - Solution not expected to change functional behavior, only performance labels Dec 18, 2024

overlookmotel marked this pull request as ready for review December 18, 2024 15:03

overlookmotel changed the base branch from 12-18-docs_ast_improve_docs_for_astbuilder_move__methods to graphite-base/7995 December 18, 2024 15:07

overlookmotel force-pushed the graphite-base/7995 branch from d0caf44 to df5c341 Compare December 18, 2024 15:12

overlookmotel force-pushed the 12-18-perf_ast_move_expression_and_move_statement_produce_dummy_with_no_span branch from 8826f46 to 570e7d0 Compare December 18, 2024 15:12

overlookmotel changed the base branch from graphite-base/7995 to main December 18, 2024 15:13

overlookmotel force-pushed the 12-18-perf_ast_move_expression_and_move_statement_produce_dummy_with_no_span branch from 570e7d0 to b92cefd Compare December 18, 2024 15:13

overlookmotel force-pushed the 12-18-perf_ast_move_expression_and_move_statement_produce_dummy_with_no_span branch 3 times, most recently from c684aa1 to 088e815 Compare December 18, 2024 23:11

overlookmotel changed the base branch from main to 12-18-feat_ast_add_astbulder_move_property_key_ December 18, 2024 23:11

overlookmotel changed the base branch from 12-18-feat_ast_add_astbulder_move_property_key_ to graphite-base/7995 December 18, 2024 23:17

overlookmotel force-pushed the graphite-base/7995 branch from ed9895d to 63a95e4 Compare December 18, 2024 23:22

overlookmotel force-pushed the 12-18-perf_ast_move_expression_and_move_statement_produce_dummy_with_no_span branch from 088e815 to 3df6665 Compare December 18, 2024 23:22

overlookmotel changed the base branch from graphite-base/7995 to main December 18, 2024 23:23

overlookmotel force-pushed the 12-18-perf_ast_move_expression_and_move_statement_produce_dummy_with_no_span branch from 3df6665 to abcdf6b Compare December 18, 2024 23:23

This was referenced Dec 19, 2024

feat(traverse): record current block scope #8007

Merged

chore(transformer): enable class-properties plugin #7750

Merged

overlookmotel force-pushed the 12-18-perf_ast_move_expression_and_move_statement_produce_dummy_with_no_span branch from abcdf6b to d0a2649 Compare December 19, 2024 20:50

overlookmotel requested a review from Dunqing as a code owner December 19, 2024 20:50

overlookmotel changed the base branch from main to 12-19-feat_transformer_class-properties_exit_faster_from_super_replacement_visitor December 19, 2024 20:50

overlookmotel mentioned this pull request Dec 19, 2024

feat(transformer/class-properties): exit faster from super replacement visitor #8028

Merged

overlookmotel force-pushed the 12-19-feat_transformer_class-properties_exit_faster_from_super_replacement_visitor branch from 957ae5b to ebdfe1b Compare December 19, 2024 22:22

overlookmotel force-pushed the 12-18-perf_ast_move_expression_and_move_statement_produce_dummy_with_no_span branch from d0a2649 to deb6c60 Compare December 19, 2024 22:23

This was referenced Dec 19, 2024

refactor(traverse)!: rename Ancestor::is_via_* methods to is_parent_of_* #8031

Merged

fix(transformer/class-properties): replace this and class name in static blocks #8035

Merged

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 20, 2024

perf(ast): move_expression and move_statement produce dummy with …

c0dd3f8

…no span (#7995) The purpose of `AstBuilder::move_*` methods is to create dummy nodes which will later be replaced again. Give the dummy nodes empty spans as it's faster, and no point in them having a real span.

Dunqing force-pushed the 12-19-feat_transformer_class-properties_exit_faster_from_super_replacement_visitor branch from ebdfe1b to 897a1a8 Compare December 20, 2024 03:11

Dunqing force-pushed the 12-18-perf_ast_move_expression_and_move_statement_produce_dummy_with_no_span branch from deb6c60 to c0dd3f8 Compare December 20, 2024 03:11

overlookmotel mentioned this pull request Dec 20, 2024

refactor(transformer/class-properties): rename file #8036

Merged

Base automatically changed from 12-19-feat_transformer_class-properties_exit_faster_from_super_replacement_visitor to main December 20, 2024 03:26

graphite-app bot merged commit c0dd3f8 into main Dec 20, 2024
27 checks passed

graphite-app bot deleted the 12-18-perf_ast_move_expression_and_move_statement_produce_dummy_with_no_span branch December 20, 2024 03:37

oxc-bot mentioned this pull request Dec 21, 2024

release(crates): v0.43.0 #8054

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(ast): `move_expression` and `move_statement` produce dummy with no span #7995

perf(ast): `move_expression` and `move_statement` produce dummy with no span #7995

overlookmotel commented Dec 18, 2024 •

edited

Loading

overlookmotel commented Dec 18, 2024 •

edited

Loading

codspeed-hq bot commented Dec 18, 2024 •

edited

Loading

graphite-app bot commented Dec 20, 2024 •

edited

Loading

perf(ast): move_expression and move_statement produce dummy with no span #7995

perf(ast): move_expression and move_statement produce dummy with no span #7995

Conversation

overlookmotel commented Dec 18, 2024 • edited Loading

overlookmotel commented Dec 18, 2024 • edited Loading

How to use the Graphite Merge Queue

codspeed-hq bot commented Dec 18, 2024 • edited Loading

CodSpeed Performance Report

Merging #7995 will not alter performance

Summary

graphite-app bot commented Dec 20, 2024 • edited Loading

Merge activity

perf(ast): `move_expression` and `move_statement` produce dummy with no span #7995

perf(ast): `move_expression` and `move_statement` produce dummy with no span #7995

overlookmotel commented Dec 18, 2024 •

edited

Loading

overlookmotel commented Dec 18, 2024 •

edited

Loading

codspeed-hq bot commented Dec 18, 2024 •

edited

Loading

graphite-app bot commented Dec 20, 2024 •

edited

Loading