Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(linter): use plugin name instead of category for finding rule #8353

Merged

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Jan 8, 2025

needed for #8329

I wanted to use proc_macro::Span::SourceFile to auto detect the plugin name. But this feature is unstable :/

Copy link

graphite-app bot commented Jan 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the A-linter Area - Linter label Jan 8, 2025
@Sysix Sysix changed the title tests(linter): use plugin name instead of category for finding rule test(linter): use plugin name instead of category for finding rule Jan 8, 2025
@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Jan 8, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #8353 will not alter performance

Comparing Sysix:refactor-linter-use-plugin-name-for-tests (2927cf4) with main (8d52cd0)

Summary

✅ 29 untouched benchmarks

@Sysix Sysix marked this pull request as ready for review January 8, 2025 18:02
@Boshen Boshen merged commit b6c1546 into oxc-project:main Jan 9, 2025
26 checks passed
Boshen added a commit that referenced this pull request Jan 13, 2025
## [0.15.6] - 2025-01-13

### Features

- 457aa31 linter: Implement `no-lone-blocks` rule (#8145) (Yuichiro
Yamashita)

### Refactor

- aea9551 ast: Simplify `get_identifier_reference` of `TSType` and
`TSTypeName` (#8273) (Dunqing)
- 43ed3e1 linter: Add output formatter (#8436) (Alexander S.)
- 4e05e66 linter: Remove glob for windows (#8390) (Alexander S.)
- b19d809 linter: Split `unicorn/prefer-spread` and
`eslint/prefer-spread` into own rules (#8329) (Alexander S.)
- 3c534ae linter: Refactor `LintBuilder` to prep for nested configs
(#8034) (camc314)
- 2f9fab9 linter: Remove remapping for plugin name in diagnostics
(#8223) (Alexander S.)

### Testing

- b6c1546 linter: Use plugin name instead of category for finding rule
(#8353) (Alexander S.)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants