Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(linter): add snapshot tester for cli #8695

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Jan 24, 2025

Our first Snapshot 🥳

@github-actions github-actions bot added A-cli Area - CLI C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Jan 24, 2025
Copy link
Collaborator Author

Sysix commented Jan 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Jan 24, 2025

CodSpeed Performance Report

Merging #8695 will not alter performance

Comparing 01-24-test_linter_add_snapshot_tester_for_cli (34d3d72) with main (b7f13e6)

Summary

✅ 33 untouched benchmarks

@Sysix Sysix marked this pull request as ready for review January 24, 2025 15:31
@Sysix Sysix force-pushed the 01-24-test_linter_add_snapshot_tester_for_cli branch 2 times, most recently from 5c1ebf7 to 6e73c22 Compare January 24, 2025 15:52
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing!

@Sysix Sysix force-pushed the 01-24-refactor_linter_move_stdout_outside_lintrunnter branch from c83ac49 to be67c56 Compare January 24, 2025 16:28
@Sysix Sysix force-pushed the 01-24-test_linter_add_snapshot_tester_for_cli branch from 6e73c22 to 52e461b Compare January 24, 2025 16:28
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 24, 2025
Copy link
Member

Boshen commented Jan 24, 2025

Merge activity

  • Jan 24, 11:40 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 24, 11:40 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 24, 11:45 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #8694.
  • Jan 24, 11:46 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #8694.
  • Jan 24, 12:06 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 24, 12:06 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 24, 12:13 PM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Jan 24, 12:14 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 24, 12:14 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jan 24, 12:19 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 24, 12:24 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 24, 2025
@Sysix Sysix force-pushed the 01-24-refactor_linter_move_stdout_outside_lintrunnter branch from be67c56 to 17c3b0a Compare January 24, 2025 16:57
@Sysix Sysix force-pushed the 01-24-test_linter_add_snapshot_tester_for_cli branch from 52e461b to 74379c4 Compare January 24, 2025 16:57
@Sysix Sysix changed the base branch from 01-24-refactor_linter_move_stdout_outside_lintrunnter to graphite-base/8695 January 24, 2025 17:05
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Jan 24, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/8695 to main January 24, 2025 17:12
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jan 24, 2025
@Sysix Sysix force-pushed the 01-24-test_linter_add_snapshot_tester_for_cli branch from 74379c4 to d017353 Compare January 24, 2025 17:14
@Sysix Sysix force-pushed the 01-24-test_linter_add_snapshot_tester_for_cli branch from d017353 to 34d3d72 Compare January 24, 2025 17:19
@graphite-app graphite-app bot merged commit 34d3d72 into main Jan 24, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 01-24-test_linter_add_snapshot_tester_for_cli branch January 24, 2025 17:24
@oxc-bot oxc-bot mentioned this pull request Feb 1, 2025
Boshen added a commit that referenced this pull request Feb 1, 2025
## [0.15.9] - 2025-02-01

### Features

- 1a41181 linter: Implement `eslint/prefer-object-spread` (#8216)
(tbashiyy)
- adb8ebd linter: Implement no-useless-call rule (#8789) (keita hino)
- 3790933 linter: Add vitest/prefer-lowercase-title rule (#8152) (Tyler
Earls)
- e8e6917 linter: Unicorn/switch-cases-braces support options (#8704)
(1zumii)

### Bug Fixes

- 8ce21d1 linter: Can't disable `no-nested-ternary` rule anymore (#8600)
(dalaoshu)
- e929f26 linter: Output `LintCommandInfo` for
`CliRunResult::LintNoFilesFound` (#8714) (Sysix)
- 4f30a17 linter: Unicorn/switch-case-braces mangles code when applying
fix (#8758) (Tyler Earls)
- 9cc9d5f linter: `ignorePatterns` does not work when files are provided
as command arguments (#8590) (dalaoshu)
- 1de6f85 linter: No-lone-blocks erroring on block statements containing
comments (#8720) (Tyler Earls)
- 77ef61a linter: Fix diagnostic spans for `oxc/no-async-await` (#8721)
(camchenry)
- f15bdce linter: Catch `Promise` in `typescript/array-type` rule
(#8702) (Rintaro Itokawa)
- 5041cb3 vscode: Fix commands by reverting commit `259a47b` (#8819)
(Alexander S.)

### Performance

- d318238 linter: Remove sorting of rules in cache (#8718) (camchenry)

### Documentation

- 57b7ca8 ast: Add documentation for all remaining JS AST methods
(#8820) (Cam McHenry)

### Refactor

- c2fdfc4 linter: Correctly handle loose options for `eslint/eqeqeq`
(#8798) (dalaoshu)
- 0aeaedd linter: Support loose options for `eslint/eqeqeq` (#8790)
(dalaoshu)
- 194a5ff linter: Remove `LintResult` (#8712) (Sysix)
- 4a2f2a9 linter: Move default `all_rules` output to trait (#8710)
(Sysix)
- 741fb40 linter: Move stdout outside LintRunner (#8694) (Sysix)
- 10e5920 linter: Move finishing default diagnostic message to
`GraphicalReporter` (#8683) (Sysix)
- 9731c56 oxlint: Move output from `CliRunResult::InvalidOption` to
outside and use more Enums for different invalid options (#8778) (Sysix)
- fe45bee oxlint: Create different `CliRunResult` instead of passing
`ExitCode` to it (#8777) (Sysix)
- 2378fef oxlint: Move ConfigFileInit output outside CliRunResult, exit
code 1 when it fails (#8776) (Sysix)
- f4cecb5 oxlint: Remove unused `CliRunResult::PathNotFound` (#8775)
(Sysix)

### Testing

- ad35e82 linter: Use snapshot testing instead of LintResult (#8711)
(Sysix)
- bf895eb linter: Add diagnostic format test snapshots (#8696)
(Alexander S.)
- 34d3d72 linter: Add snapshot tester for cli (#8695) (Sysix)
- 0bf2bcf oxlint: Test two real rules with same name but from different
plugins (#8821) (dalaoshu)
- 2b83b71 oxlint: Improve disabling "no-nested-ternary" tests (#8814)
(Alexander S.)
- 45648e7 oxlint: Fix InvalidOptionTsConfig tests for windows (#8791)
(Alexander S.)
- 48bfed9 oxlint: Ignore windows path mismatch (Boshen)
- 6f4a023 oxlint: Remove "--print-config" test (#8792) (Sysix)
- 55c2025 oxlint: Add `CliRunResult` to snapshot (#8780) (Sysix)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-cli Area - CLI C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants