refactor(linter): remove usage of url crate
#8833
Merged
+71
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camchenry
force-pushed
the
02-01-refactor_linter_remove_usage_of_url_crate
branch
from
c056d26 to
325753b
Compare
CodSpeed Performance ReportMerging #8833 will not alter performanceComparing Summary
|
camchenry
force-pushed
the
02-01-refactor_linter_replace_mime_guessing_with_extension_check
branch
from
580e5e6 to
12ac972
Compare
camchenry
force-pushed
the
02-01-refactor_linter_remove_usage_of_url_crate
branch
from
325753b to
8f9f16e
Compare
camchenry
force-pushed
the
02-01-refactor_linter_replace_mime_guessing_with_extension_check
branch
from
12ac972 to
684c783
Compare
camchenry
force-pushed
the
02-01-refactor_linter_remove_usage_of_url_crate
branch
from
8f9f16e to
6d5b697
Compare
camchenry
force-pushed
the
02-01-refactor_linter_replace_mime_guessing_with_extension_check
branch
from
684c783 to
b2c2cfc
Compare
camchenry
force-pushed
the
02-01-refactor_linter_remove_usage_of_url_crate
branch
from
6d5b697 to
0a949a2
Compare
camchenry
force-pushed
the
02-01-refactor_linter_replace_mime_guessing_with_extension_check
branch
from
b2c2cfc to
e956297
Compare
camchenry
force-pushed
the
02-01-refactor_linter_remove_usage_of_url_crate
branch
from
0a949a2 to
1da9e1b
Compare
Merge activity
|
In the linter, this was only used for getting a query parameter value out of a URL. These lint rules already check that the URL value is a known-good URL so we don't need to validate and parse it. I've replaced these usages with a simple helper function to get the value from the query string. There was also a usage in the tasks directory for getting test files and I've also skipped validating here since it's not strictly necessary as we control all inputs.
graphite-app
bot
force-pushed
the
02-01-refactor_linter_replace_mime_guessing_with_extension_check
branch
from
e956297 to
4fcf719
Compare
graphite-app
bot
force-pushed
the
02-01-refactor_linter_remove_usage_of_url_crate
branch
from
1da9e1b to
bb9d763
Compare
Base automatically changed from
02-01-refactor_linter_replace_mime_guessing_with_extension_check
to
main
February 2, 2025 01:23
graphite-app
bot
deleted the
02-01-refactor_linter_remove_usage_of_url_crate
branch
Boshen
added a commit
that referenced
this pull request
Feb 6, 2025
## [0.15.10] - 2025-02-06 ### Features - d6d80f7 linter: Add suggestion fixer for `eslint/no-iterator` (#8894) (dalaoshu) - 7e8568b linter: Junit reporter (#8756) (Tapan Prakash) - f4662a9 oxc_language_server: Implement `oxc.fixAll` workspace command (#8858) (Marek Vospel) ### Bug Fixes - baf3e4e linter: Correctly replace rule severity with duplicate rule name configurations (#8840) (dalaoshu) ### Performance - 8a4988d linter: Use parallel iterator directly instead of iter and parallel bridge (#8831) (Cam McHenry) ### Refactor - bb9d763 linter: Remove usage of `url` crate (#8833) (camchenry) - 4fcf719 linter: Replace MIME guessing with extension check (#8832) (camchenry) Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the linter, this was only used for getting a query parameter value out of a URL. These lint rules already check that the URL value is a known-good URL so we don't need to validate and parse it. I've replaced these usages with a simple helper function to get the value from the query string.
There was also a usage in the tasks directory for getting test files and I've also skipped validating here since it's not strictly necessary as we control all inputs.