Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add init-declarations rule #8909

Merged

Conversation

huangtiandi1999
Copy link
Contributor

Copy link

graphite-app bot commented Feb 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Feb 5, 2025
@Sysix
Copy link
Collaborator

Sysix commented Feb 5, 2025

thanks you 👍
the eslint rules looks great. only problem: we need to support the typescript version too:
https://typescript-eslint.io/rules/init-declarations/

Could you please extend your rule to support it too?
You can generate the typescript rule and copy the tests into the eslint file (remapping happens automatically)

@huangtiandi1999
Copy link
Contributor Author

hi @Sysix , I have finished supporting typescript declare, please help to review it 👍

Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #8909 will not alter performance

Comparing huangtiandi1999:feat/linter/init-declarations (5a0a0b6) with main (515eb52)

Summary

✅ 33 untouched benchmarks

@Sysix Sysix merged commit 41ad42a into oxc-project:main Feb 7, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants