fix(linter): no-global-assign look into globals config
#8963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #8963 will not alter performanceComparing Summary
|
Sysix
force-pushed
the
02-07-fix_linter_no-global-assign_look_for_globals_entry_too
branch
4 times, most recently
from
ae663d2 to
7b10cad
Compare
Sysix
changed the title
no-global-assign look for globals entry toono-global-assign look into globals config
Sysix
force-pushed
the
02-07-fix_linter_no-global-assign_look_for_globals_entry_too
branch
from
a33460a to
7b10cad
Compare
Merge activity
|
Sysix
force-pushed
the
02-07-fix_linter_no-global-assign_look_for_globals_entry_too
branch
from
7b10cad to
5d5278d
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 8, 2025
`no-global-assign` should report when `readonly` global variables are written. Also the rule did only look into `env` and not into `global` too. Created a new `ctx` pub function. Will maybe refactor other places. I think they have some problems too :)
graphite-app
bot
force-pushed
the
02-07-fix_linter_no-global-assign_look_for_globals_entry_too
branch
from
5d5278d to
03de103
Compare
|
There was no failing test for it. I added one after the merge-label |
`no-global-assign` should report when `readonly` global variables are written. Also the rule did only look into `env` and not into `global` too. Created a new `ctx` pub function. Will maybe refactor other places. I think they have some problems too :)
graphite-app
bot
force-pushed
the
02-07-fix_linter_no-global-assign_look_for_globals_entry_too
branch
from
03de103 to
b191390
Compare
graphite-app
bot
deleted the
02-07-fix_linter_no-global-assign_look_for_globals_entry_too
branch
Dunqing
pushed a commit
that referenced
this pull request
Feb 10, 2025
`no-global-assign` should report when `readonly` global variables are written. Also the rule did only look into `env` and not into `global` too. Created a new `ctx` pub function. Will maybe refactor other places. I think they have some problems too :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-global-assignshould report whenreadonlyglobal variables are written.Also the rule did only look into
envand not intoglobaltoo.Created a new
ctxpub function. Will maybe refactor other places. I think they have some problems too :)