Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): rule promise/avoid-new do not look into globals #9144

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Feb 15, 2025

No description provided.

Copy link
Collaborator Author

Sysix commented Feb 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Feb 15, 2025

CodSpeed Performance Report

Merging #9144 will create unknown performance changes

Comparing 02-15-fix_linter_rule_promise_avoid-new_do_not_look_into_globals_ (b36734c) with 02-15-fix_linter_rule_no-new-native-nonconstructor_do_not_look_into_globals (091a5c1)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 25 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 68.4 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 720.5 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.6 µs N/A
🆕 lexer[antd.js] N/A 22 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.2 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.6 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.8 s N/A
🆕 mangler[antd.js] N/A 16.2 ms N/A
🆕 mangler[react.development.js] N/A 299.2 µs N/A
🆕 mangler[typescript.js] N/A 39.9 ms N/A
🆕 minifier[antd.js] N/A 161.2 ms N/A
🆕 minifier[react.development.js] N/A 1.7 ms N/A
🆕 minifier[typescript.js] N/A 280.4 ms N/A
🆕 estree[checker.ts] N/A 189.8 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 87.6 µs N/A
🆕 parser[antd.js] N/A 106.6 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link
Member

Boshen commented Feb 15, 2025

Merge activity

  • Feb 15, 10:04 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 15, 10:04 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 15, 10:43 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 02-15-fix_linter_rule_no-new-native-nonconstructor_do_not_look_into_globals branch from 568ae02 to 091a5c1 Compare February 15, 2025 15:07
@graphite-app graphite-app bot force-pushed the 02-15-fix_linter_rule_promise_avoid-new_do_not_look_into_globals_ branch from f398628 to b36734c Compare February 15, 2025 15:08
Base automatically changed from 02-15-fix_linter_rule_no-new-native-nonconstructor_do_not_look_into_globals to main February 15, 2025 15:40
@graphite-app graphite-app bot merged commit b36734c into main Feb 15, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 02-15-fix_linter_rule_promise_avoid-new_do_not_look_into_globals_ branch February 15, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants