Added the updated delivery status UI #1079
Conversation
There was a problem hiding this comment.
It might be a good idea to add in this dynamic message status logic in MessageDetailActivity.kt at line 74, we get an error message which is just hard-coded, at least we should replace it with the new string and possibly use logos or something else if we want to add more to that page
| val (iconID, iconColor) = getMessageStatusImage(message) | ||
| val (iconID, iconColor, textId) = getMessageStatusImage(message) | ||
| if (textId != null) { | ||
| binding.messageStatusTextView.setText(textId) |
There was a problem hiding this comment.
we might have to set the text to null in the null case as well so that re-binds that should have a null message status don't keep the old value (as they won't be set this way)
There was a problem hiding this comment.
it might not be an issue if we are controlling the visibility so that this case should never happen though I guess
There was a problem hiding this comment.
I updated the visibility logic so if the textId or iconID are null then the UI elements will be hidden to prevent the chance that stale data will be shown - let me know if you also want be to null-out the data
@hjubb Where/what is this error message? (can you get a screenshot of it easily?) |
@mpretty-cyro I think we just fallback to a generic error if we don't have a DB error message, which is usually whatever the exception message usually is so might not be that important in the end, unless we just wanted the generic message not use the hardcoded string value but get |
Ah, I didn't realise this screen even existed 😅 So we actually chatted about failed message errors a few days ago (in the context of iOS) and the decision was to actually show the network/server error if we have one rather than something generic (since it could help for support purposes) so I'm not sure we actually do want to make this generic We are also likely going to need to update this UI as part of the message info improvements so we can probably get clarity (and make changes) as part of that work - let me know if you stuff want it done now though |
|
it's probably fine for now @mpretty-cyro we can improve this screen quite a bit in the future I'm sure |
…updates # Conflicts: # app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/VisibleMessageView.kt # app/src/main/res/values/strings.xml
No description provided.