Fixed a few bugs, added logging and removed some old code #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mpretty-cyro
commented
Feb 3, 2023
•
mpretty-cyro
commented
- Added the ability to copy the sessionId of open group URL from the conversation menu
- Added additional logging to the BatchMessageReceiveJob to make future debugging easier
- Increase upload size to ~10Mb
- Removed the OpenGroupMigrator
- Updated the JobQueue logging to provide more insight
- Fixed an issue where the database migrations weren't blocking which could result in failing/crashing SQL queries
- Fixed an issue where the new database file wouldn't be removed if a migration error was thrown
- Fixed an issue where the new database could exist in an invalid state and the app wouldn't attempt to remigrate
- Fixed an incorrectly throw exception in the PassphrasePromptActivity
Added the ability to copy the sessionId of open group URL from the conversation menu Added additional logging to the BatchMessageReceiveJob to make future debugging easier Removed the OpenGroupMigrator Updated the JobQueue logging to provide more insight Fixed an issue where the database migrations weren't blocking which could result in failing/crashing SQL queries Fixed an issue where the new database file wouldn't be removed if a migration error was thrown Fixed an issue where the new database could exist in an invalid state and the app wouldn't attempt to remigrate Fixed an incorrectly throw exception in the PassphrasePromptActivity
hjubb
approved these changes
Feb 3, 2023
|
Looking fantastic so good to see all this work happening and the old bugs getting fixed, and especially small new features like the ability to copy the sessionId of open group URL on Android devices will make the user experience so nice for so many people great job 🤩🥳😊😀 |
hjubb
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.