Fixed a few issues related to the GroupAvatarDownloadJob #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mpretty-cyro
commented
Feb 8, 2023
mpretty-cyro
commented
- Added logic to avoid scheduling a GroupAvatarDownloadJob if there is already an existing one with the same parameters
- Added logic to avoid trying to download an old avatar for a group if there is a new one
- Added logic to prevent an old GroupAvatarDownloadJob from overriding a valid avatar with an old one
Added logic to avoid scheduling a GroupAvatarDownloadJob if there is already an existing one with the same parameters Added logic to avoid trying to download an old avatar for a group if there is a new one Added logic to prevent an old GroupAvatarDownloadJob from overriding a valid avatar with an old one
hjubb
reviewed
Feb 8, 2023
libsession/src/main/java/org/session/libsession/messaging/jobs/GroupAvatarDownloadJob.kt
Show resolved
Hide resolved
hjubb
previously approved these changes
Feb 9, 2023
Added a method to remove the Group avatar Fixed an issue where the recipient diffing on the HomeActivity wasn't working properly Fixed an issue where the GroupAvatarDownloadJob could be scheduled even when there was already one scheduled
|
@hjubb Sorry, I came across another issue so need this re-reviewed - also added the logic for handling a group avatar being removed |
hjubb
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.