Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase contrast between selected messages and window background. Fixes #1110 (Plan B) #1116

Merged
merged 1 commit into from Feb 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2023

First time contributor checklist

Contributor checklist

  • I have tested my contribution on these devices:
  • Virtual device Pixel 6 API 33, Android 13.0
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

See https://github.com/oxen-io/session-android/issues/1110#issuecomment-1426331553 for screenshots.

@ghost
Copy link
Author

ghost commented Feb 10, 2023

I submitted two pull requests, will close one of them based on feedback, feel free to comment / vote.

Plan A: #1115

Copy link

@hjubb hjubb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is it possible to change the base to dev?

@ghost ghost changed the base branch from master to dev February 13, 2023 07:15
@ghost
Copy link
Author

ghost commented Feb 13, 2023

I rebased on dev and force pushed @hjubb

@hjubb
Copy link

hjubb commented Feb 13, 2023

Thanks for that, merging now

@hjubb hjubb merged commit 47066a3 into oxen-io:dev Feb 13, 2023
@ghost ghost deleted the theme-selected-message-contrast-plan-b branch February 13, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant