Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scroll to bottom button visibility #1219

Merged
merged 2 commits into from
May 30, 2023
Merged

Fix scroll to bottom button visibility #1219

merged 2 commits into from
May 30, 2023

Conversation

bemusementpark
Copy link

@bemusementpark bemusementpark commented May 25, 2023 •
edited
Loading

There were a few issues.

  1. Because we sometimes use reverseOrder in the RecyclerView, items are at the bottom of the RecyclerView, so I had to constrain offset with max(0, offset).
  2. When we have the keyboard open and then we long press a message the keyboard will be hidden. We need to hide the button when the emojiPicker is visible. But handleRecyclerViewScrolled was being called changing the visibility. So this PR adds an emojiPickerVisible field to make sure they are not shown together.
device-2023-05-25-154412.webm

@bemusementpark bemusementpark requested a review from hjubb May 25, 2023 06:12
@bemusementpark bemusementpark merged commit e8d2622 into oxen-io:dev May 30, 2023
@bemusementpark bemusementpark deleted the fix-scroll-button branch May 30, 2023 02:14
@mpretty-cyro mpretty-cyro mentioned this pull request Jun 5, 2023
Merged
burtonemily pushed a commit to burtonemily/session-android that referenced this pull request Aug 1, 2023
@bemusementpark @burtonemily
Fix scroll to bottom button visibility (oxen-io#1219)
0aef1cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjubb hjubb hjubb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bemusementpark @hjubb