[SES-1754] Fix message menu icons not visible in light theme #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bemusementpark
changed the title
AL-Session
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Works for all themes so thumbs up.
However, is the line saying, essentially: "Use the value of 'color', or if that's null then use the looked up color from the attribute"?
If so, when would we expect color to be null? (it's set as item.color?.let { ContextCompat.getColor(context, it) }) - wouldn't it make more sense to just use the lookup from attribute always, and then later it gets reset for the title & subtitle etc. anyways...
Entirely up to you, but just curious about the thinking behind it! :)
|
I'm using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after