Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean CallManager etc #1557

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Clean CallManager etc #1557

merged 2 commits into from
Jul 19, 2024

Conversation

bemusementpark
Copy link

@bemusementpark bemusementpark commented Jul 19, 2024 •
edited
Loading

  • There was warnings on private val hangupTelephonyCallback by lazy as it was API 31+, I wrapped that up in a interface TelephonyHandler.
  • We were trying to catch ForegroundServiceStartNotAllowedException not available on all APIs, I broadened this to super IllegalStateException, and logged the exception, which was missed.
  • cleaned up a when (action) { statement
  • formatting
  • Fixed some properties that were declared twice
  • Fixed a StateFlow that was exposed as MutableStateFlow

@bemusementpark bemusementpark merged commit c3a342a into oxen-io:dev Jul 19, 2024
1 check passed
@bemusementpark bemusementpark deleted the clean-calls branch July 19, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasSession ThomasSession ThomasSession approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bemusementpark @ThomasSession