Fix crashes on conversation screen

[simophin]

This should fix issues reported on Google Play Store:

The underlying problem is the suspend function throws an exception instead of using the ResultOf system.

Exception org.session.libsession.snode.OnionRequestAPI$HTTPRequestFailedAtDestinationException:
  at org.session.libsession.snode.OnionRequestAPI.handleResponse (OnionRequestAPI.kt:611)
  at org.session.libsession.snode.OnionRequestAPI.access$handleResponse (OnionRequestAPI.kt:38)
  at org.session.libsession.snode.OnionRequestAPI$sendOnionRequest$1$1.invoke (OnionRequestAPI.kt:378)
  at org.session.libsession.snode.OnionRequestAPI$sendOnionRequest$1$1.invoke (OnionRequestAPI.kt:375)
  at org.session.libsignal.utilities.ThreadUtils.queue$lambda$0 (ThreadUtils.kt:29)
  at org.session.libsignal.utilities.ThreadUtils.$r8$lambda$fBVaDXxK1lXFamZwYyxWNzVYu18
  at org.session.libsignal.utilities.ThreadUtils$$ExternalSyntheticLambda0.run
  at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run (LimitedDispatcher.kt:115)
  at kotlinx.coroutines.scheduling.TaskImpl.run (Tasks.kt:103)
  at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely (CoroutineScheduler.kt:584)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask (CoroutineScheduler.kt:793)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker (CoroutineScheduler.kt:697)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run (CoroutineScheduler.kt:684)

[ThomasSession]

Ah nice I had these changes on my todo list...
Did you check that the receiving end of each of these call handle the error properly? Do they do anything with it?

[bemusementpark]

oh, looks better, but should we just move to Result?

[simophin]

Yep it's now kotlin.Result