Share SecureRandom #1594
Merged
Share SecureRandom #1594
+98
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -248,32 +246,6 @@ object Util { | |||
| return result | |||
| } | |||
|
|
|||
| fun getSecretBytes(size: Int): ByteArray { | |||
There was a problem hiding this comment.
Nice clean up!
Looking at the files there are a whole bunch more of seemingly unused functions. Might be worth removing those as well if they are truly unused.
There was a problem hiding this comment.
I removed getRandomLengthBytes because it creates a SecureRandom and it's probably better to delete an unused function than maintain it. I didn't want to get too distracted deleting all unused functions in files touched.
| @@ -458,12 +459,6 @@ public void setActive(String groupId, boolean active) { | |||
| database.update(TABLE_NAME, values, GROUP_ID + " = ?", new String[] {groupId}); | |||
| } | |||
|
|
|||
| public byte[] allocateGroupId() { | |||
There was a problem hiding this comment.
Seems like there are a few other unused functions in there, might be worth cleaning it while we're doing this.
There was a problem hiding this comment.
ditto.
public byte[] allocateGroupId() {
byte[] groupId = new byte[16];
new SecureRandom().nextBytes(groupId);
return groupId;
}
ThomasSession
approved these changes
Aug 4, 2024
simophin
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every usage of
SecureRandomcreated a new instance. This is inefficient. This PR adds a sharedSecureRandomthat is used throughout the app.Additionally this PR cleans up some other unused usages of
SecureRandom, and adds extension functionsshuffledSecure,randomSecureandrandomSecureOrNullwhich are all pretty obvious enough if you have a look.