forked from signalapp/Signal-Android
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/strings updates #1659
Merged
Merged
Feature/strings updates #1659
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
f241328
Fixing styling issue in unread scroll to bottom button
ThomasSession 32acd6e
Fixing up styling of Prominent buttons and "view_user" to work better…
ThomasSession 28d59f9
Fixing strings
ThomasSession ea24ff6
Strings fixes
ThomasSession 97db1fe
Reworked preferences
ThomasSession 2704bc7
Updated the fake message in appearance
ThomasSession 4aa68c9
Adding the ability to copy in message details
ThomasSession 4d47354
Showing 'copy account id' in menu in 1to1 too
ThomasSession ffbb7d8
Updating files tab in "All media"
ThomasSession 2f4c605
Strings updates
ThomasSession 81f56de
Latest strings and handling bold
ThomasSession 86f89f8
Updated constants file
ThomasSession d7bd0bf
Can save media in message details page now
ThomasSession bc067b6
Adding padding so that context menu doesn't hit the bottom of the screen
ThomasSession 3db8b46
Strings update
ThomasSession 7f8e9fd
Reverted changes on DMs
ThomasSession 14207c7
Better ripple for home FAB
ThomasSession 2c3e73b
Added a control message when the current user accepts a message request
ThomasSession a7843af
Updated QR screen to show dialog when permission is permanently denied
ThomasSession fa90b74
Using the Compose version of our QR scanning
ThomasSession 4fd3961
Comments for future changes in JoinCommunityFragment
ThomasSession 139f4ba
New strings + new camera permission handling
ThomasSession 5795998
Making sure we do not crash when making/receiving a call without the …
ThomasSession 4860adc
Added a new control message type to handle missed calls due to permis…
ThomasSession f44d066
Changed the missed call control message logic
ThomasSession 2174976
Do not change the text color on emioji picker
ThomasSession aef0adb
[SES-2695] Incorrect message request approval on home screen
c38efc2
WIP for new avatar selection
ThomasSession c633338
Merge branch 'feature/strings-updates' of https://github.com/oxen-io/…
ThomasSession c0bf015
SES-2651 - New avatar picker
ThomasSession 422b8b2
Fixing the remaining tasks
ThomasSession ae64189
Differentiating between voice notes and regular audio
ThomasSession 4e2cef6
Fixing 'Leave group dialog' from inside the group settings
ThomasSession 1761024
SES-2692 only save valid media in message details
ThomasSession 87e3f93
SES-2675 - Standardisingdenied mic permission
ThomasSession 85161ff
PR comment
ThomasSession 83b08cc
Fixing Camera permissions
ThomasSession File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we converted
IncomingMediaMessage
to Kotlin we could have named arguments, because that constructor is absolutely grim and invites mistakes!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that is a nice update that we can work on post strings