Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations messages.json (ja) #1228

Closed
wants to merge 7 commits into from
Closed

Update translations messages.json (ja) #1228

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 8, 2020

First time contributor checklist:

Contributor checklist:

Description

  • Some Japanese translations added.
  • Sorry, I'm not very familiar with the program. Please let me know if anything is wrong.

Some Japanese translations added.
@Mikunj
Copy link

Mikunj commented Jul 10, 2020

Hey @akked, thanks for adding translations. It seems you have removed some old translated strings which were in Japanese and are now in English. Can you please re-update the translations and only change the messages which aren't translated or incorrectly translated?

For example:

 "deleteAndRestart": {
        "message": "Delete all data and restart",
        "description": "Shown in a popup if the database cannot start up properly; allows user to dalete database and restart"
    },
    "mainMenuFile": {
        "message": "ファイル (&F)",
        "description": "The label that is used for the File menu in the program main menu. The '&' indicates that the following letter will be used as the keyboard 'shortcut letter' for accessing the menu with the Alt-<letter> combination."
    }

The above would become:

 "deleteAndRestart": {
        "message": <New translation here>,
        "description": "Shown in a popup if the database cannot start up properly; allows user to dalete database and restart"
    },
    "mainMenuFile": {
        "message": "ファイル (&F)",
        "description": "The label that is used for the File menu in the program main menu. The '&' indicates that the following letter will be used as the keyboard 'shortcut letter' for accessing the menu with the Alt-<letter> combination."
    },

@ghost
Copy link
Author

ghost commented Jul 10, 2020

@Mikunj ,Should I translate all the strings?
It may take some time, but I'll do it.

@Mikunj
Copy link

Mikunj commented Jul 10, 2020

@Mikunj ,Should I translate all the strings?
It may take some time, but I'll do it.

Oh that would be great if you could :)

@Mikunj
Copy link

Mikunj commented Jul 13, 2020

I'll mark this as Draft for now and once you are done you can mark it ready for review :)

@Mikunj Mikunj marked this pull request as draft July 13, 2020 00:56
@Mikunj Mikunj self-requested a review July 13, 2020 00:56
@ghost
Copy link
Author

ghost commented Jul 27, 2020

Hello, @Mikunj
Probably all japanese translations are complete.

@ghost ghost marked this pull request as ready for review July 27, 2020 02:53
@Mikunj
Copy link

Mikunj commented Jul 27, 2020

Sweet thanks for this, we'll get this looked over and merged 👍

@Bilb
Copy link
Collaborator

Bilb commented Mar 16, 2021

Closing this as we merged #1533

@Bilb Bilb closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants