Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration progress banner #1846

Merged
merged 21 commits into from
Aug 19, 2021

Conversation

warrickct
Copy link

@warrickct warrickct commented Aug 13, 2021

  • Adds a small banner for instruction on storing recovery phrase securely on first signup. Banner fades away once the user copies their phrase.
  • Also adds deletion of redux persisted settings upon account deletion.

progress-banner
progress-banner2
progress-banner-3

@Bilb
Copy link
Collaborator

Bilb commented Aug 16, 2021

I am not 100% sure about the difference between those two screens. Why cannot they be one only? User click on the button, and the seed is displayed, no ?

progress-banner
progress-banner2

I think it would be enough to just open the Seed dialog to let the user copy its seed from there, rather than showing that part of the UI:

progress-banner-3

@warrickct
Copy link
Author

@Bilb Sure, I can combine them. It was just based off the original design on Android. Sure thing, I can also move the recovery phrase part to a modal dialog.

@Bilb
Copy link
Collaborator

Bilb commented Aug 17, 2021

@Bilb Sure, I can combine them. It was just based off the original design on Android. Sure thing, I can also move the recovery phrase part to a modal dialog.

there is already a seed dialog. It's the one shwon on click on the settings => show recovery phrase button. Just display this one when the user clicks on your button

@warrickct
Copy link
Author

warrickct commented Aug 17, 2021

there is already a seed dialog. It's the one shwon on click on the settings => show recovery phrase button. Just display this one when the user clicks on your button

Yup I saw that modal. I've added it in this morning, I was just refactoring it to a functional component. Just a few minor changes after lunch and I'll push the changes.

@Bilb Bilb merged commit d325626 into oxen-io:clearnet Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants