added perfect negotiation #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrickct
commented
Oct 1, 2021
warrickct
commented
- Adds toast for missed call and when calling without mic/cam permissions.
- Adds handling for missed call
- Adds negotiation handling
Adding toast for cam and audio permission when making a call. adding missed call message and toast when a call is received while mid-call. background call message work
Bilb
reviewed
Oct 1, 2021
_locales/en/messages.json
Outdated
| "endCall": "End call", | ||
| "micAndCameraPermissionNeededTitle": "Camera and Microphone access required", | ||
| "micAndCameraPermissionNeeded": "You can enable microphone and camera access under: Settings (Gear icon) => Privacy", | ||
| "unableToCall": "Cancel your exiting call session.", |
There was a problem hiding this comment.
exiSting
and make itL
cancel your ongoing call first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.