fix: message text should wrap without causing extremely wide messages #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
Unfortunately, this also breaks the flow of messages containing normal language:
See how "pretty" is wrapped mid-word? Not ideal. |
|
Hi @ianmacd good catch! That's my mistake. I'll sort it out on Monday. Thank you for bringing it to my attention. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
clearnetbranchyarn readyrun passes successfully (more about tests here)Description
When we have long messages with a link, the link wraps below the text and causes a large amount of white space. It would be better for the link text to wrap around.
Before:
After:
