fix: skip attachment without path when replying to a message #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen if the attachment is still downloading, or could not be downloaded. The message will have attachments or thumbnails, without valid data associated to it. This fix makes sure we don't try to load invalid paths when trying to gather the attachments and previews
Bilb
force-pushed
the
fix-replying-attachment-failing
branch
from
b41b713 to
c0cc745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if the attachment is still downloading, or could not be
downloaded. The message will have attachments or thumbnails, without
valid data associated to it.
This fix makes sure we don't try to load invalid paths when trying to
gather the attachments and previews