forked from signalapp/Signal-Desktop
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding Chunk 1 #3056
Merged
Merged
Onboarding Chunk 1 #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including eslint plugins to latest
you don't need it from react 17
fixed some weird import errors
tested out styled components compatbility with the MessageHighlighter component
import specific types from react package
…r_motion Feat/ses 912/react18 and framer motion
converted session-loader sass to styled components
added copy for onboarding account loading
with already have an account copy
added into test region of right panel
including improved error messaging and removing the label
still need to do the slide animation
with sliding down animation if an error occurs
intial run at legal links modal
we are moving it to a separate onboarding store
added new modal confirm buttons, only tested in classic dark for onboarding
cleaned up some sass and changed to styled components
we simplified the hero responsiveness
typings for free() on a wrapper which we use to clear in memory only wrappers in some cases
this prevents refreshing of the entire styled component on render
tweaked svg styling
transition duration is now set via a function for integration testing purposes
fixes builds on windows
fixed style position
brought improvements from chunk 2
updated to use building block svgs
even though its chunk 2
required since upgrading styled-components
improved global window types for persistStore and inboxStore, we now await the persist store purge in deleteDbLocally
lgtm |
Bilb
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.