forked from signalapp/Signal-Desktop
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: randomly pick a snode to poll from until we build a better way with changes server side #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
force-pushed
the
fix-retrieve-snode-down
branch
from
April 17, 2024 05:24
e3c7d3a
to
52ebcfd
Compare
yougotwill
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢🤞
Bilb
force-pushed
the
fix-retrieve-snode-down
branch
4 times, most recently
from
April 24, 2024 03:46
d28f0cd
to
92ee3c8
Compare
Bilb
force-pushed
the
fix-retrieve-snode-down
branch
from
April 25, 2024 06:27
92ee3c8
to
0b97739
Compare
also: - add comments about not adding the limit:256 on snode list fetch - fix an issue when no audio are found when starting a webrtc call
Bilb
force-pushed
the
fix-retrieve-snode-down
branch
4 times, most recently
from
April 29, 2024 00:43
a6ee465
to
93c21ec
Compare
Bilb
force-pushed
the
fix-retrieve-snode-down
branch
from
April 29, 2024 00:49
93c21ec
to
faa24ce
Compare
yougotwill
requested changes
Apr 29, 2024
yougotwill
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for QA! 🕵️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.