Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: randomly pick a snode to poll from until we build a better way with changes server side #3080

Merged
merged 8 commits into from
May 1, 2024

Conversation

Bilb
Copy link
Collaborator

@Bilb Bilb commented Apr 17, 2024

No description provided.

@Bilb Bilb force-pushed the fix-retrieve-snode-down branch from e3c7d3a to 52ebcfd Compare April 17, 2024 05:24
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢🤞

ts/session/apis/snode_api/retrieveRequest.ts Outdated Show resolved Hide resolved
@Bilb Bilb force-pushed the fix-retrieve-snode-down branch 4 times, most recently from d28f0cd to 92ee3c8 Compare April 24, 2024 03:46
@Bilb Bilb force-pushed the fix-retrieve-snode-down branch from 92ee3c8 to 0b97739 Compare April 25, 2024 06:27
also:
- add comments about not adding the limit:256 on snode list fetch
- fix an issue when no audio are found when starting a webrtc call
@Bilb Bilb force-pushed the fix-retrieve-snode-down branch 4 times, most recently from a6ee465 to 93c21ec Compare April 29, 2024 00:43
@Bilb Bilb force-pushed the fix-retrieve-snode-down branch from 93c21ec to faa24ce Compare April 29, 2024 00:49
ts/components/leftpane/LeftPaneSettingSection.tsx Outdated Show resolved Hide resolved
ts/session/apis/seed_node_api/SeedNodeAPI.ts Outdated Show resolved Hide resolved
ts/session/apis/snode_api/SnodeRequestTypes.ts Outdated Show resolved Hide resolved
ts/session/apis/snode_api/getServiceNodesList.ts Outdated Show resolved Hide resolved
ts/session/apis/snode_api/retrieveRequest.ts Outdated Show resolved Hide resolved
ts/session/apis/snode_api/retrieveRequest.ts Outdated Show resolved Hide resolved
ts/state/ducks/settings.tsx Outdated Show resolved Hide resolved
ts/types/ReduxTypes.d.ts Show resolved Hide resolved
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for QA! 🕵️

ts/session/apis/seed_node_api/SeedNodeAPI.ts Outdated Show resolved Hide resolved
@Bilb Bilb merged commit 4eafe8c into oxen-io:unstable May 1, 2024
6 checks passed
@Bilb Bilb deleted the fix-retrieve-snode-down branch May 1, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants