Onboarding Chunk 2 #3083
Merged
Onboarding Chunk 2 #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved some parts into the leftpanesectionheader
this will replace the sessionideditable eventually still needs error handling etc
it is still used
only show button when users enters something
created new ActionRow component
fix styles for other overlays
since we swapped some toast messages for input messages
updated error correction to 25%
updated account id and recovery password qr codes with logos
qr code logos can now be svgs for better rendering performance
monospaced, biggerText, isTextArea
some config messages are not handled correctly and we need to know why
disabled conversation header functionality
11 has been deprecated
using libsession COMMUNITY_FULL_URL_MAX_LENGTH
using libsession BASE_GROUP_MAX_NAME_LENGTH
makes error reporting easier
… display name remove privateKeyBytesHex since we don't use it
for various convo duck, convo interactions, convo model and opengroup types
don't use testing functions to generate a temp secret key rather do it manually
user details dialog is now a fixed width
yougotwill
force-pushed
the
feat/ses-825/onboarding2
branch
from
6ce969a to
8ea7daa
Compare
Bilb
requested changes
Jul 25, 2024
| const result = renderComponent( | ||
| // NOTE we need to test the pubkey to color generation and ordering with appium. Since we can't access the value of a css variable in with the current unit test setup | ||
| <AvatarPlaceHolder | ||
| diameter={AvatarSize.XL} |
There was a problem hiding this comment.
can we not at least verify that the string var(--color-xxx) is the right one for each pubkeys?
There was a problem hiding this comment.
Unfortunately not because it possible from the component because the color is just the primary color variable. I wanted avoid abstrating the color generation into a function. Which is what strated unit testing components in the first place. I can do that and then we can test the individual color values.
i.e. The color prop returned is var(--primar-color) it does not resolve to a hex code
since it caused overflow, disabled buttons when making a group
unneeded promise object returned
Bilb
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review has been done on Will’s fork:yougotwill#43Edit: Chunk 1 has been merged so we can do the final review here