Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch snode storage version and filter for edge snode #3124

Merged
merged 4 commits into from
Jul 23, 2024
Merged

feat: fetch snode storage version and filter for edge snode #3124

merged 4 commits into from
Jul 23, 2024

Conversation

Bilb
Copy link
Collaborator

@Bilb Bilb commented Jul 23, 2024

No description provided.

@Bilb Bilb force-pushed the use-storage-server-version-for-edge-snode branch from 44ef1f3 to df92d5f Compare July 23, 2024 01:39
yougotwill
yougotwill requested changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work but one small change please

ts/test/test-utils/utils/pubkey.ts Show resolved Hide resolved
ts/test/session/unit/onion/OnionPaths_test.ts Show resolved Hide resolved
ts/session/onions/onionPath.ts Show resolved Hide resolved
ts/session/onions/onionPath.ts Show resolved Hide resolved
ts/session/onions/onionPath.ts Show resolved Hide resolved
ts/session/onions/onionPath.ts Show resolved Hide resolved
@Bilb Bilb force-pushed the use-storage-server-version-for-edge-snode branch from df92d5f to e5da3cc Compare July 23, 2024 03:31
@Bilb Bilb force-pushed the use-storage-server-version-for-edge-snode branch from e5da3cc to 420bd3c Compare July 23, 2024 03:37
@Bilb Bilb changed the base branch from unstable to clearnet July 23, 2024 03:39
yougotwill
yougotwill approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Bilb Bilb merged commit 5b76a1f into oxen-io:clearnet Jul 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yougotwill yougotwill yougotwill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bilb @yougotwill