Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocked list inaccessiable on smaller screens #3131

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Blocked list inaccessiable on smaller screens #3131

merged 6 commits into from
Aug 7, 2024

Conversation

yougotwill
Copy link
Collaborator

Before

Screenshot 2024-07-26 at 15 05 53 Screenshot 2024-07-26 at 15 05 18

After

Screenshot 2024-07-26 at 15 09 03 Screenshot 2024-07-26 at 15 08 55

Bilb
Bilb requested changes Jul 26, 2024
View reviewed changes
ts/components/MemberListItem.tsx Outdated Show resolved Hide resolved
ts/components/settings/BlockedList.tsx Show resolved Hide resolved
ts/components/settings/BlockedList.tsx Outdated Show resolved Hide resolved
yougotwill
yougotwill commented Jul 26, 2024
View reviewed changes
Copy link
Collaborator Author

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded

ts/components/MemberListItem.tsx Outdated Show resolved Hide resolved
ts/components/settings/BlockedList.tsx Show resolved Hide resolved
ts/components/settings/BlockedList.tsx Outdated Show resolved Hide resolved
Bilb and others added 2 commits July 29, 2024 10:55
@Bilb
fix: blocked list overflow by setting parent width correctly
4b0b813
@yougotwill
fix: remove unneeded maxWidth
f0836de 
correct text alignment for enter key settings for smaller screens
@Bilb
Copy link
Collaborator

Bilb commented Jul 29, 2024

lgtm

@Bilb Bilb self-requested a review July 29, 2024 01:15
@yougotwill yougotwill changed the title Hotfix: Blocked list inaccessiable on smaller screens Blocked list inaccessiable on smaller screens Aug 7, 2024
@yougotwill yougotwill changed the base branch from master to unstable August 7, 2024 01:01
@burtonemily burtonemily self-assigned this Aug 7, 2024
@yougotwill yougotwill merged commit 1e3f7f6 into oxen-io:unstable Aug 7, 2024
@yougotwill yougotwill deleted the fix/ses-2426/block_contacts_height branch August 7, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bilb Bilb Bilb approved these changes

Assignees

@burtonemily burtonemily

Labels
qa-tested Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yougotwill @Bilb @burtonemily