Skip to content

Commit

Permalink
Fixes "Serial console interferes with scroll bar" #989 (#1396)
Browse files Browse the repository at this point in the history
* Fixes #989

* Removed now that canvas renderer is an addon
  • Loading branch information
benjaminleonard authored Mar 13, 2023
1 parent 211a7d8 commit ddd8a45
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 19 deletions.
3 changes: 1 addition & 2 deletions app/components/Terminal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ interface TerminalProps {
const options: ITerminalOptions = {
allowTransparency: false,
screenReaderMode: true,
rendererType: 'dom',
fontFamily: '"GT America Mono", monospace',
fontSize: 13,
lineHeight: 1.2,
Expand Down Expand Up @@ -86,7 +85,7 @@ export const Terminal = ({ data }: TerminalProps) => {

return (
<>
<div className="h-full w-full pr-12" ref={terminalRef} />
<div className="h-full w-[calc(100%-3rem)]" ref={terminalRef} />
<div className="absolute right-0 top-0 space-y-2 text-secondary">
<ScrollButton onClick={() => term?.scrollToTop()}>
<DirectionUpIcon />
Expand Down
30 changes: 15 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@
"tslib": "^2.5.0",
"tunnel-rat": "^0.0.4",
"uuid": "^8.3.2",
"xterm": "^4.18.0",
"xterm-addon-fit": "^0.5.0",
"xterm": "^5.1.0",
"xterm-addon-fit": "^0.7.0",
"zod": "^3.19.1",
"zustand": "^4.0.0"
},
Expand Down

1 comment on commit ddd8a45

@vercel
Copy link

@vercel vercel bot commented on ddd8a45 Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.