Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add params arg to invalidateQueries #2410

Closed
wants to merge 2 commits into from

Conversation

david-crespo
Copy link
Collaborator

This feels slightly worse somehow. I have liked not having the params arg on invalidateQueries.

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Sep 3, 2024 8:05pm

@charliepark
Copy link
Contributor

Personally, the if at the callsite helps highlight the intent of the code a bit more clearly to me, and I do like it without the params prop. That being said, I don't have strong feelings on it.

@david-crespo david-crespo deleted the invalidateQueries-tweak branch September 3, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants