Fix missing write stats in Oximeter. #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2025 16:43
Made a common "stat update" function Added a call to the stat update function when a write "would have" been acked had we not fast-acked it already. While I was here, I also updated some paths for dtrace scripts and update column width for upstairs_count.d script.
leftwo
commented
Jan 28, 2025
| @@ -558,14 +566,52 @@ impl Downstairs { | |||
|
|
|||
| // Fire DTrace probes and update stats | |||
| let io_size = done.io_size(); | |||
| match &done.work { | |||
| let work = done.work.clone(); | |||
| Self::update_io_done_stats(&self.stats, work, ds_id, io_size); | |||
There was a problem hiding this comment.
Ahh. github diff made a mess of this.
I pulled the stat update part of ack_job() out to a stand alone function, but
the diff thinks I changed more of ack_job() than I really did. There should be
almost nothing else different
mkeeter
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write stats were not making it to Oximeter any longer. Sometime in the recent changes we stopped calling the method that updated both DTrace probes for write completion and calling the
add_writethat would eventually make it to Oximeter.To do this, I made a common "stat update" function and added a call to the stat update function when a write "would have" been acked had we not fast-acked it already.
While I was here, I also updated some paths for dtrace scripts and updated column width for upstairs_count.d script.
Fixes #1615
After the changes on my bench gimlet you can see writes now:
